Messages in this thread | | | Date | Mon, 19 May 2014 10:04:05 -0400 | From | Jason Cooper <> | Subject | Re: [PATCH v2 05/06] staging: crypto: skein: rename macros |
| |
On Mon, May 19, 2014 at 12:08:39PM +0300, Dan Carpenter wrote: > On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote: > > +/* ignore all asserts, for performance */ > > +#define skein_assert_ret(x, ret_code) > > +#define skein_assert(x) > > Not related to this patch, but defining away asserts like this is a bad > idea. What if they have side affects like: > > skein_assert(foo++ == bar);
Agreed. This driver is definitely a work in progress. If you look at the history, you'll see that I started with a bit-for-bit copy of a publicly available reference implementation. After we get the coding style in shape, there are plenty of other improvements to make.
Thanks for the review.
thx,
Jason.
| |