Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH RFC] Remove useless return variables | Date | Sat, 17 May 2014 22:04:35 -0700 |
| |
Peter Senna Tschudin <peter.senna@gmail.com> writes:
> This patch remove variables that are initialized with a constant, > are never updated, and are only used as parameter of return. > Return the constant instead of using a variable.
This ret variable pattern is pretty standard in Linux, as it makes it easier to add new code that may trigger new errors (using the usual "goto forest" error handling pattern)
I don't see any benefit in whole-sale removing it. The compiler doesn't care about it and will generate the same code in any case.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |