lkml.org 
[lkml]   [2014]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] e1000e: Out of line __ew32_prepare/__ew32
On Fri, 16 May 2014 14:43:11 -0700
Andi Kleen <andi@firstfloor.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
>
> Out of lining these two common inlines saves about 30k text size,
> due to their errata workarounds.
>
> 14131431 2008136 1507328 17646895 10d452f vmlinux-before-e1000e
> 14101415 2004040 1507328 17612783 10cbfef vmlinux-e1000e
>
> Cc: jeffrey.t.kirsher@intel.com
> Cc: netdev@vger.kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Since you are making a formerly private function global, the name
should be unique. I.e prefix it with e1000_




\
 
 \ /
  Last update: 2014-05-17 06:01    [W:0.145 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site