lkml.org 
[lkml]   [2014]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv5 2/5] ARM: EXYNOS: Support secondary CPU boot of Exynos3250
    Hi,

    On 13.05.2014 15:05, Chanwoo Choi wrote:
    > This patch fix the offset of CPU boot address and don't need to send smc call
    > of SMC_CMD_CPU1BOOT command for secondary CPU boot because Exynos3250 removes
    > WFE in secure mode.
    >
    > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
    > Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
    > ---
    > arch/arm/mach-exynos/firmware.c | 9 ++++++++-
    > 1 file changed, 8 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
    > index 739bdc8..eb91d23 100644
    > --- a/arch/arm/mach-exynos/firmware.c
    > +++ b/arch/arm/mach-exynos/firmware.c
    > @@ -30,6 +30,13 @@ static int exynos_do_idle(void)
    > static int exynos_cpu_boot(int cpu)
    > {
    > /*
    > + * Exynos3250 doesn't need to send smc command for secondary CPU boot
    > + * because Exynos3250 removes WFE in secure mode.
    > + */
    > + if (soc_is_exynos3250())
    > + return 0;
    > +
    > + /*
    > * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
    > * But, Exynos4212 has only one secondary CPU so second parameter
    > * isn't used for informing secure firmware about CPU id.
    > @@ -50,7 +57,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
    >
    > boot_reg = sysram_ns_base_addr + 0x1c;
    >
    > - if (!soc_is_exynos4212())
    > + if (!soc_is_exynos4212() && !soc_is_exynos3250())
    > boot_reg += 4*cpu;
    >
    > __raw_writel(boot_addr, boot_reg);
    >

    Reviewed-by: Tomasz Figa <t.figa@samsung.com>

    Best regards,
    Tomasz


    \
     
     \ /
      Last update: 2014-05-14 22:01    [W:2.356 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site