lkml.org 
[lkml]   [2014]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On 05/13, Srinivas Kandagatla wrote:
> Thanks Linus W,
>
> On 13/05/14 08:16, Linus Walleij wrote:
> >On Tue, Apr 29, 2014 at 10:19 AM, <srinivas.kandagatla@linaro.org> wrote:
> >
> >>From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >>This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci
> >>driver.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >(...)
> >>+ AMBA_VENDOR_QCOM = 0x51,
> >
> >Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention
> >this in the commit message.
> >
> Sounds good, I will fix it in next version and send it to Russell's
> patch tracker.
>

Please add a note that this id is fake in the commit text or in
the code as well.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


\
 
 \ /
  Last update: 2014-05-14 10:21    [W:0.649 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site