Messages in this thread | | | Date | Tue, 13 May 2014 18:45:52 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions. |
| |
On Tue, May 13, 2014 at 05:06:10PM +0100, David Howells wrote: > NeilBrown <neilb@suse.de> wrote: > > > The wait_on_bit() call in __fscache_wait_on_invalidate() was ambiguous > > as it specified TASK_UNINTERRUPTIBLE but used > > fscache_wait_bit_interruptible as an action function. > > As any error return is never checked I assumed that 'uninterruptible' > > was correct. > > Bug. It should be uninterruptible in both places.
Thanks David, queued the patch!
| |