Messages in this thread | | | Date | Tue, 13 May 2014 10:36:27 +0100 | From | Srinivas Kandagatla <> | Subject | Re: [PATCH v1 08/11] mmc: mmci: Qcom fix MCICLK register settings. |
| |
Thanks Linus W.
On 13/05/14 09:19, Linus Walleij wrote: > Again follow the pattern of storing register templates in the vendor_data > struct. I think you will quickly realize how this can be cut down with > new fields like .clk_4bitmode etc. > >> > /* Modified PL180 on Versatile Express platform */ >> > #define MCI_ARM_HWFCEN (1 << 12) >> > >> >+/* Modified on Qualcomm Integrations */ > First: follow the convention set for the ST-specific registers that > look e.g. like this: I agree, Will fix these in next version. > > MCI_ST_8BIT_BUS i.e. MCI_<vendor>_SPECIFIER > So the below becomes MCI_QCOM_CLK_WIDEBUS... etc. >
| |