lkml.org 
[lkml]   [2014]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 07/11] mmc: mmci: move ST specific register extensions access under condition.


On 13/05/14 09:08, Linus Walleij wrote:
>> > /* Keep ST Micro busy mode if enabled */
>> >- datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE;
>> >+ if (host->hw_designer == AMBA_VENDOR_ST)
>> >+ datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE;
> Do not hard-check the hw_designer everywhere, follow the pattern
> if storing special stuff in the variant data.
>
Got it, I will fix this across other patches too.

> struct variant_data {
> u32 datactrl_mask_busymode;
> (...)
>
> static struct variant_data variant_u300 = {
> .datactrl_mask_busymode = MCI_ST_DPSM_BUSYMODE,
> (...)
> static struct variant_data variant_nomadik = {


\
 
 \ /
  Last update: 2014-05-13 12:21    [W:0.098 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site