lkml.org 
[lkml]   [2014]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] RFT: pinctrl: sunxi: convert to GPIO irqchip helpers
    On Mon, May 12, 2014 at 11:29:11AM +0200, Linus Walleij wrote:
    > On Sun, May 11, 2014 at 11:25 PM, Maxime Ripard
    > <maxime.ripard@free-electrons.com> wrote:
    >
    > > What I did so far is having a single domain, with the same handler
    > > registered for all the interrupts, and the various interrupts from the
    > > various banks just being at a different offsets in the domain.
    > >
    > > Basically, something like that:
    > > http://code.bulix.org/ym3zuv-86191
    > >
    > > Do you know if it would be possible to use the generic gpiolib
    > > behaviour in such a case?
    >
    > Basically the helpers are for the simple case where every pin
    > can fire an independent interrupt.
    >
    > Since there is just one single irqdomain for the entire chip, the
    > helpers require that all mappings go through the same domain.
    >
    > If having several domains or other split-up results in more
    > elegant code, then code another solution locally, because we
    > just want to cover the generic cases, the special cases will still
    > be special.
    >
    > Unless you see some really elegant way forward of course...
    > always choose the most elegand refactoring if you can.

    Ok, I'll see what I can come up with then, and give your patch some
    testing.

    Thanks!
    Maxime

    --
    Maxime Ripard, Free Electrons
    Embedded Linux, Kernel and Android engineering
    http://free-electrons.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-05-12 22:21    [W:4.181 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site