Messages in this thread | | | Date | Tue, 8 Apr 2014 17:18:25 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] Kbuild: move extra gcc check flags to the top Makefile |
| |
On Tue, Apr 08, 2014 at 05:06:57PM +0200, Michal Marek wrote: > On 2014-04-07 05:22, Masahiro Yamada wrote: > > If W=... given to the command line, extra gcc check flags are added > > to KBUILD_CFLAGS. > > > > If we have such code in scripts/Makefile.build, the same flags are > > added to KBUILD_CFLAGS multiple times becuase scripts/Makefile.build > > is invoked every time Kbuild descends into the subdirectories. > > Indeed. For three years, nobody has noticed that the gcc commandline is > growing with every subdirectory. I once had a patchset that moved all this out - to avoid this. It was lost for various reasons.
The top-level Makefile is already too cluttered - so adding all this is not good. Moving it all to a dedicated file would be better.
Sam
| |