Messages in this thread | | | Subject | Re: [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7 interface" | From | Benjamin Herrenschmidt <> | Date | Mon, 07 Apr 2014 09:48:30 +1000 |
| |
On Wed, 2014-04-02 at 15:10 -0700, Cody P Schafer wrote: > Make the "not enabled" message less awful. > > Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com> > --- > arch/powerpc/perf/hv-24x7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c > index 297c9105..3246ea2 100644 > --- a/arch/powerpc/perf/hv-24x7.c > +++ b/arch/powerpc/perf/hv-24x7.c > @@ -491,7 +491,7 @@ static int hv_24x7_init(void) > > hret = hv_perf_caps_get(&caps); > if (hret) { > - pr_info("could not obtain capabilities, error 0x%80lx, not enabling\n", > + pr_info("could not obtain capabilities, not enabling (%ld)\n", > hret);
That's not much less awful... The message gives 0 informations about where it comes from .. what is it that couldn't obtain capabilities ?
Also, sentences start with a Capital.
Cheers, Ben.
| |