lkml.org 
[lkml]   [2014]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver
Date
On Friday, April 04, 2014 at 11:49:39 AM, sourav wrote:

[...]

> > +/* Functions for DMA support */
> > +static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
> > + dma_addr_t phy_addr)
> > +{
> > + struct imx_i2c_dma *dma;
> > + struct dma_slave_config dma_sconfig;
> > + struct device *dev =&i2c_imx->adapter.dev;
> > + int ret;
> > +
> > + dma = devm_kzalloc(dev, sizeof(struct imx_i2c_dma), GFP_KERNEL);
> > + if (!dma) {
> > + dev_info(dev, "can't allocate DMA struct\n");
> > + return -ENOMEM;
> > + }
> > +
> > + dma->chan_tx = dma_request_slave_channel(dev, "tx");
> > + return 0;
>
> ?? Looks to be some leftover?

Nice find.

btw. you might want to trim the email only to the relevant parts when replying
so it's easier to find your commments in the entire body of text.

> > + if (!dma->chan_tx) {
> > + dev_info(dev, "DMA tx channel request failed\n");
> > + ret = -ENODEV;
> > + goto fail_al;
> > + }

[...]

Best regards,
Marek Vasut


\
 
 \ /
  Last update: 2014-04-04 15:01    [W:0.096 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site