| Subject | Re: [PATCH 11/47] staging/lustre/ptlrpc: add rpc_cache | From | Oleg Drokin <> | Date | Tue, 29 Apr 2014 23:22:58 -0400 |
| |
Hello!
On Apr 29, 2014, at 5:46 AM, Dan Carpenter wrote: >> >> + /* Fall through */ >> case 7: >> sptlrpc_fini(); >> - case 5: >> + /* Fall through */ >> + case 6: >> ldlm_exit(); >> - case 4: >> + /* Fall through */ >> + case 5: >> ptlrpc_stop_pinger(); >> - case 3: >> + /* Fall through */ >> + case 4: >> ptlrpc_connection_fini(); >> - case 2: >> + /* Fall through */ >> + case 3: >> ptlrpc_exit_portals(); >> + /* Fall through */ >> + case 2: >> + ptlrpc_request_cache_fini(); >> + /* Fall through */ >> case 1: >> ptlrpc_hr_fini(); >> req_layout_fini(); >> + /* Fall through */ >> default: ; >> } >> > > Heh. Oh wow. That's horrible. :P > > Hopefully next time someone will fix this pile of monkey poo instead > just renumbering all the grains of corn.
Agreed. We actually have it fixed, but it again came with some other rework that we are probably not ready to merge anywhere yet. I guess I can extract just this cleanup ahead of time.
Bye, Oleg
|