lkml.org 
[lkml]   [2014]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 11/47] staging/lustre/ptlrpc: add rpc_cache
From
Date
Hello!

On Apr 29, 2014, at 5:46 AM, Dan Carpenter wrote:
>>
>> + /* Fall through */
>> case 7:
>> sptlrpc_fini();
>> - case 5:
>> + /* Fall through */
>> + case 6:
>> ldlm_exit();
>> - case 4:
>> + /* Fall through */
>> + case 5:
>> ptlrpc_stop_pinger();
>> - case 3:
>> + /* Fall through */
>> + case 4:
>> ptlrpc_connection_fini();
>> - case 2:
>> + /* Fall through */
>> + case 3:
>> ptlrpc_exit_portals();
>> + /* Fall through */
>> + case 2:
>> + ptlrpc_request_cache_fini();
>> + /* Fall through */
>> case 1:
>> ptlrpc_hr_fini();
>> req_layout_fini();
>> + /* Fall through */
>> default: ;
>> }
>>
>
> Heh. Oh wow. That's horrible. :P
>
> Hopefully next time someone will fix this pile of monkey poo instead
> just renumbering all the grains of corn.

Agreed.
We actually have it fixed, but it again came with some other rework that
we are probably not ready to merge anywhere yet.
I guess I can extract just this cleanup ahead of time.

Bye,
Oleg


\
 
 \ /
  Last update: 2014-04-30 05:41    [W:1.889 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site