Messages in this thread | | | Date | Tue, 29 Apr 2014 11:24:15 +0200 | From | Pavel Machek <> | Subject | Re: [PATCHv3 4/5] Input: tsc2005: add DT support |
| |
On Sat 2014-04-26 01:56:18, Sebastian Reichel wrote: > This adds DT support to the tsc2005 touchscreen > driver. > > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> @@ -100,6 +102,11 @@ > TSC2005_CFR2_AVG_7) > > #define MAX_12BIT 0xfff > +#define TSC2005_DEF_X_FUZZ 4 > +#define TSC2005_DEF_Y_FUZZ 8 > +#define TSC2005_DEF_P_FUZZ 2 > +#define TSC2005_DEF_RESISTOR 280 >
IMO using defines insteaed of plain numbers does not help readability much, but ....
Reviewed-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |