lkml.org 
[lkml]   [2014]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/2] KVM: async_pf: change async_pf_execute() to use get_user_pages(tsk => NULL)
    Il 28/04/2014 17:03, Oleg Nesterov ha scritto:
    > async_pf_execute() passes tsk == current to gup(), this is doesn't
    > hurt but unnecessary and misleading. "tsk" is only used to account
    > the number of faults and current is the random workqueue thread.
    >
    > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    > ---
    > virt/kvm/async_pf.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c
    > index 0ced4f3..62f4223 100644
    > --- a/virt/kvm/async_pf.c
    > +++ b/virt/kvm/async_pf.c
    > @@ -81,7 +81,7 @@ static void async_pf_execute(struct work_struct *work)
    > might_sleep();
    >
    > down_read(&mm->mmap_sem);
    > - get_user_pages(current, mm, addr, 1, 1, 0, NULL, NULL);
    > + get_user_pages(NULL, mm, addr, 1, 1, 0, NULL, NULL);
    > up_read(&mm->mmap_sem);
    > kvm_async_page_present_sync(vcpu, apf);
    >
    >

    Thanks, added a Suggested-by for Andrea and applied together with 1/2 to
    kvm/queue.

    (Actually, I'm back from a longish vacation and I have a pretty large
    queue, so I haven't even compile tested these for now. Once I get round
    to at least smoke-test them, I'll really push to kvm/queue).

    Paolo


    \
     
     \ /
      Last update: 2014-04-28 18:01    [W:8.934 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site