Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload | Date | Sat, 26 Apr 2014 02:24:14 +0000 |
| |
> -----Original Message----- > From: Eric Dumazet [mailto:eric.dumazet@gmail.com] > Sent: Friday, April 25, 2014 6:15 PM > To: Stephen Hemminger > Cc: KY Srinivasan; davem@davemloft.net; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > apw@canonical.com; jasowang@redhat.com; stable@kernel.org > Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > > On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote: > > On Fri, 25 Apr 2014 11:45:14 -0700 > > "K. Y. Srinivasan" <kys@microsoft.com> wrote: > > > > > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, > struct net_device *net) > > > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi + > > > ppi->ppi_offset); > > > > > > + ip_hdr(skb)->check = 0; > > > + csum_info->transmit.ip_header_checksum = 1; > > > + > > > if (net_trans_info & (INFO_IPV4 << 16)) > > > csum_info->transmit.is_ipv4 = 1; > > > else > > > > Linux doesn't need or want IP checksum offload. > > It will not have any performance gain. > > > BTW, was this patch even tested with IPv6 packets ???
No; I only tested this on ipv4.
K. Y >
| |