Messages in this thread | | | Date | Thu, 24 Apr 2014 13:34:38 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCHSET 00/11] perf tools: Fixup for the --percentage change (v3) |
| |
On Thu, Apr 24, 2014 at 05:23:52PM +0900, Namhyung Kim wrote:
SNIP
> > So yes, it has a same problem of inaccurate number of samples, but its > impact should be smaller than other stats - seeing increasing sample > count (could be slightly inaccurate) without new entries in the browser. > > * changes in v3) > - split patch 2/7 into parts (Jiri) > - fix a segfault when filtering with unfolded entry (Jiri)
other than my comment for patch 4 it seems ok to me
thanks, jirka
| |