lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 042/182] mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC
    Date
    3.11.10.9 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Herve Codina <Herve.CODINA@celad.com>

    commit 90445ff6241e2a13445310803e2efa606c61f276 upstream.

    Crash detected on sam5d35 and its pmecc nand ecc controller.

    The problem was a call to chip->ecc.hwctl from nand_write_subpage_hwecc
    (nand_base.c) when we write a sub page.
    chip->ecc.hwctl function is not set when we are using PMECC controller.
    As a workaround, set NAND_NO_SUBPAGE_WRITE for PMECC controller in
    order to disable sub page access in nand_write_page.

    Signed-off-by: Herve Codina <Herve.CODINA@celad.com>
    Acked-by: Josh Wu <josh.wu@atmel.com>
    Signed-off-by: Brian Norris <computersforpeace@gmail.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/mtd/nand/atmel_nand.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
    index 2d23d29..cc69e41 100644
    --- a/drivers/mtd/nand/atmel_nand.c
    +++ b/drivers/mtd/nand/atmel_nand.c
    @@ -1096,6 +1096,7 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
    goto err_pmecc_data_alloc;
    }

    + nand_chip->options |= NAND_NO_SUBPAGE_WRITE;
    nand_chip->ecc.read_page = atmel_nand_pmecc_read_page;
    nand_chip->ecc.write_page = atmel_nand_pmecc_write_page;

    --
    1.9.1


    \
     
     \ /
      Last update: 2014-04-24 11:01    [W:2.067 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site