lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 117/182] pid_namespace: pidns_get() should check task_active_pid_ns() != NULL
    Date
    3.11.10.9 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Oleg Nesterov <oleg@redhat.com>

    commit d23082257d83e4bc89727d5aedee197e907999d2 upstream.

    pidns_get()->get_pid_ns() can hit ns == NULL. This task_struct can't
    go away, but task_active_pid_ns(task) is NULL if release_task(task)
    was already called. Alternatively we could change get_pid_ns(ns) to
    check ns != NULL, but it seems that other callers are fine.

    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Cc: Eric W. Biederman ebiederm@xmission.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    kernel/pid_namespace.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
    index 601bb36..2a953de 100644
    --- a/kernel/pid_namespace.c
    +++ b/kernel/pid_namespace.c
    @@ -312,7 +312,9 @@ static void *pidns_get(struct task_struct *task)
    struct pid_namespace *ns;

    rcu_read_lock();
    - ns = get_pid_ns(task_active_pid_ns(task));
    + ns = task_active_pid_ns(task);
    + if (ns)
    + get_pid_ns(ns);
    rcu_read_unlock();

    return ns;
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-04-26 16:41    [W:4.147 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site