lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.
From
Hi dan

it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK TL-WN723N).
my mistake i should have added "Tested-by" tag for all patches.

Tested-by: navin patidar <navin.patidar@gmail.com>

regards,
--navin-patidar

On Tue, Apr 22, 2014 at 3:41 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote:
>> _ReadLEDSetting() doesn't read led settings this function actually
>> initialize member variables of struct led_priv, we should do that
>> inside rtl8188eu_InitSwLeds().
>>
>
> This seems like a bugfix or is it just a cleanup? It's not clear to me
> from the patch description. Have you tested this patch?
>
> regards,
> dan carpenter
>


\
 
 \ /
  Last update: 2014-04-22 16:21    [W:0.135 / U:2.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site