lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vfs: rw_copy_check_uvector() - free iov on error
On Tue, Apr 22, 2014 at 10:42:52AM +0200, Miklos Szeredi wrote:

> > > Your patch looks a lot more complete than the quick hack I did a few
> > > days ago when coverity first started nagging about this, but in testing
> > > I've found that something really ugly starts showing up when you patch this
> > >
> > > The symptoms vary, but always are some kind of slab corruption.
> > > Here's the last example:
> > >
> > > The crash happens very quickly (within a few seconds of running trinity) for me.
> >
> > Al, Miklos ?
>
> I probably am blind, but I can't see how that will cause slab corruption.
>
> Have you verified that it's just that single patch and no other change?

yeah, runs a lot longer (before eventually hitting other issues) without
the patch.

Dave



\
 
 \ /
  Last update: 2014-04-22 16:01    [W:0.090 / U:1.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site