Messages in this thread | | | Date | Tue, 22 Apr 2014 16:30:20 +0100 | From | Srinivas Kandagatla <> | Subject | Re: [PATCH v6 06/19] usb: phy: msm: Fix checkpatch.pl warnings |
| |
On 22/04/14 10:20, Ivan T. Ivanov wrote: > @@ -79,8 +78,7 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init) > ret = regulator_set_voltage(motg->vddcx, 0, > USB_PHY_VDD_DIG_VOL_MAX); > if (ret) > - dev_err(motg->phy.dev, "unable to set the voltage " > - "for hsusb vddcx\n"); > + dev_err(motg->phy.dev, "Cannot set vddcx voltage\n");
> @@ -137,15 +133,13 @@ static int msm_hsusb_ldo_set_mode(struct msm_otg *motg, int on) > ret = regulator_set_optimum_mode(motg->v1p8, > USB_PHY_1P8_HPM_LOAD); > if (ret < 0) { > - pr_err("%s: Unable to set HPM of the regulator " > - "HSUSB_1p8\n", __func__); > + pr_err("Could not set HPM for v1p8\n"); > return ret; > }
> @@ -390,8 +382,7 @@ static int msm_hsusb_config_vddcx(struct msm_otg *motg, int high) > > ret = regulator_set_voltage(motg->vddcx, min_vol, max_vol); > if (ret) { > - pr_err("%s: unable to set the voltage for regulator " > - "HSUSB_VDDCX\n", __func__); > + dev_err(motg->phy.dev, "Cannot set vddcx voltage\n"); > return ret; > } >
I see some of pr_err not moved to dev_err?, while others have been moved.
Also noticed that the error messages are changed as part of this fix. IMHO, changing an error message would have a side-effects on logging tools, anyway Am not sure if its true in this case.
Thanks, srini
| |