Messages in this thread | | | Date | Mon, 21 Apr 2014 18:38:04 -0400 | From | Tejun Heo <> | Subject | Re: [RFC PATCH v5 1/2] Use lock_device_hotplug() in cpu_probe_store() and cpu_release_store() |
| |
Hello,
On Mon, Apr 21, 2014 at 05:20:59PM +0800, Li Zhong wrote: > While auditing the usage of lock_device_hotplug_sysfs() for implementing > it in another way in following patch, it seems to me that the code here > is to add/remove device, and the files probe/release for cpu bus > themselves won't be removed. > > So it seems to me there is no s_active related deadlock here, and we > could just use lock_device_hotplug().
It may still cause issue if offlining ends up removing sysfs files or gets involved with the same lock used during cpu hot[un]plug operations (e.g. offlining racing against cpu hotunplug) and offlining a cpu does remove files. Has this change been tested?
Thanks.
-- tejun
| |