lkml.org 
[lkml]   [2014]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] netconsole: Add tty driver
    Struan Bartlett <struan.bartlett@gmail.com> :
    [...]
    > --- a/drivers/net/netconsole.c 2014-03-31 04:40:15.000000000 +0100
    > +++ b/drivers/net/netconsole.c 2014-04-01 11:58:50.000000000 +0100
    > @@ -15,6 +15,7 @@
    > * generic card hooks
    > * works non-modular
    > * 2003-09-07 rewritten with netpoll api
    > + * 2014-03-31 tty driver by Struan Bartlett

    Useless.

    [...]
    > +static int netconsole_tty_put_char(struct tty_struct *tty, unsigned char ch)
    > +{
    > + char temp[2] = { ch, 0 };
    > + _write_msg(temp, 1);

    Please add an empty line after declaration.

    [...]
    > @@ -802,11 +857,39 @@ static int __init init_netconsole(void)
    > if (err)
    > goto undonotifier;
    >
    > + netconsole_tty_driver = alloc_tty_driver(1);

    alloc_tty_driver is said deprecated in include/linux/tty_driver.h

    http://marc.info/?l=linux-netdev&m=139629339513575 may delay things a bit.
    If so please be patient.

    --
    Ueimor


    \
     
     \ /
      Last update: 2014-04-03 02:01    [W:5.110 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site