Messages in this thread | | | Date | Wed, 2 Apr 2014 10:11:15 +0400 | From | Vladimir Davydov <> | Subject | Re: [PATCH -mm v2 2/2] mm: get rid of __GFP_KMEMCG |
| |
On 04/02/2014 04:48 AM, Greg Thelen wrote: > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 3dd389aa91c7..6d6959292e00 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -358,17 +358,6 @@ kmem_cache_alloc_node_trace(struct kmem_cache *s, > #include <linux/slub_def.h> > #endif > > -static __always_inline void * > -kmalloc_order(size_t size, gfp_t flags, unsigned int order) > -{ > - void *ret; > - > - flags |= (__GFP_COMP | __GFP_KMEMCG); > - ret = (void *) __get_free_pages(flags, order); > - kmemleak_alloc(ret, size, 1, flags); > - return ret; > -} > - > Removing this from the header file breaks builds without > CONFIG_TRACING. > Example: > % make allnoconfig && make -j4 mm/ > [...] > include/linux/slab.h: In function ‘kmalloc_order_trace’: > include/linux/slab.h:367:2: error: implicit declaration of function ‘kmalloc_order’ [-Werror=implicit-function-declaration]
Oh, my bad - forgot to add the function declaration :-(
The fixed version is on its way. Thank you for catching this! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |