Messages in this thread Patch in this message | | | From | Takashi Iwai <> | Subject | [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path | Date | Wed, 2 Apr 2014 12:29:41 +0200 |
| |
ttyprintk driver calls tty_unregister_driver() wrongly in the error path of tty_register_driver(). Also, setting ttyprintk_driver to NULL is utterly superfluous, so let's get rid of it, too.
Reported-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Takashi Iwai <tiwai@suse.de> --- drivers/char/ttyprintk.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c index daea84c41743..2a39c5790364 100644 --- a/drivers/char/ttyprintk.c +++ b/drivers/char/ttyprintk.c @@ -210,10 +210,8 @@ static int __init ttyprintk_init(void) return 0; error: - tty_unregister_driver(ttyprintk_driver); put_tty_driver(ttyprintk_driver); tty_port_destroy(&tpk_port.port); - ttyprintk_driver = NULL; return ret; } device_initcall(ttyprintk_init); -- 1.9.1
| |