Messages in this thread | | | Date | Fri, 18 Apr 2014 14:26:14 -0400 | From | Johannes Weiner <> | Subject | Re: [PATCH RFC -mm v2 3/3] memcg, slab: simplify synchronization scheme |
| |
On Fri, Apr 18, 2014 at 08:08:17PM +0400, Vladimir Davydov wrote: > On 04/18/2014 06:17 PM, Johannes Weiner wrote: > > I like this patch, but the API names are confusing. Could we fix up > > that whole thing by any chance? Some suggestions below, but they > > might only be marginally better... > > Yeah, names are inconsistent in kmemcg and desperately want improvement: > > mem_cgroup_destroy_all_caches > kmem_cgroup_css_offline > memcg_kmem_get_cache > memcg_charge_kmem > memcg_create_cache_name > > I've been thinking on cleaning this up for some time, but couldn't make > up my mind to do this. I think it cannot wait any more now, so my next > patch set will rework kmemcg naming. > > Can we apply this patch as is for now? It'd be more convenient for me to > rework naming on top of the end picture.
Yes, absolutely. For this patch:
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |