| Date | Tue, 15 Apr 2014 14:43:30 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC PATCHC 2/3] idle: store the idle state the cpu is |
| |
On Fri, Mar 28, 2014 at 01:29:55PM +0100, Daniel Lezcano wrote: > @@ -143,6 +145,10 @@ static int cpuidle_idle_call(void) > if (!ret) { > trace_cpu_idle_rcuidle(next_state, dev->cpu); > > + *power = &drv->states[next_state].power; > + > + wmb(); > +
I very much suspect you meant: smp_wmb(), as I don't see the hardware reading that pointer, therefore UP wouldn't care. Also, any and all barriers should come with a comment that describes the data ordering and points to the matchin barriers.
|