lkml.org 
[lkml]   [2014]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] drivers/pci/pcie/portdrv_pci.c: coding style fixes
On Sun, Apr 13, 2014 at 09:49:34AM +0200, Fabian Frederick wrote:
> Move __initdata before equal sign
> printk(KERN_WARNING converted to pr_warn
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/pci/pcie/portdrv_pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 0d8fdc4..14eb431 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -402,7 +402,7 @@ static int __init dmi_pcie_pme_disable_msi(const struct dmi_system_id *d)
> return 0;
> }
>
> -static struct dmi_system_id __initdata pcie_portdrv_dmi_table[] = {
> +static struct dmi_system_id pcie_portdrv_dmi_table[] __initdata = {
> /*
> * Boxes that should not use MSI for PCIe PME signaling.
> */
> @@ -429,7 +429,7 @@ static int __init pcie_portdrv_init(void)
>
> retval = pcie_port_bus_register();
> if (retval) {
> - printk(KERN_WARNING "PCIE: bus_register error: %d\n", retval);
> + pr_warn("PCIE: bus_register error: %d\n", retval);

Hi Fabian,

Can you do similar printk conversions for everything in drivers/pci,
so we do it all at once? I think there are a few left that could be
converted to dev_info() or similar, so watch for those, too.

Bjorn

> goto out;
> }
> retval = pci_register_driver(&pcie_portdriver);
> --
> 1.8.3.2
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2014-04-15 02:41    [W:0.066 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site