lkml.org 
[lkml]   [2014]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] Fix alignement problems in drivers/staging/crystalhd/crystalhd_lnx.c
On Sun, Apr 13, 2014 at 11:26:15PM +0200, Paul Bolle wrote:
> On Mon, 2014-04-14 at 00:02 +0300, Dan Carpenter wrote:
> > The subeject should be:
> >
> > [PATCH v2 1/3] Staging: crystalhd: Fix alignement in crystalhd_lnx.c
> >
> > Please resend it. Also you should use shorter subject lines.
> >
> > "Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c"
> >
> > This is too long. Say:
> >
> > "Remove a stray space character in crystalhd_lnx.c"
>
> The commit explanation also was a copy of the subject line.

Huh? No it wasn't.

> That
> suggests that the explanation can be dropped.

The long description was fine. It included a copy of the error message
and everything.

> Many trivial fixes can
> (and should) be submitted without a commit explanation.
>

Don't encourage people to leave out the commit message. They can figure
out on their own when that is appropriate. In my experience people only
err on the other side, by not commenting enough. I've only rarely been
annoyed by a long description which was too long.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-04-14 00:21    [W:0.048 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site