Messages in this thread | | | Subject | Re: [PATCH 1/3] sched,numa: count pages on active node as local | From | Joe Perches <> | Date | Fri, 11 Apr 2014 10:34:33 -0700 |
| |
On Fri, 2014-04-11 at 13:00 -0400, riel@redhat.com wrote: > This should reduce the overhead of the automatic NUMA placement > code, when a workload spans multiple NUMA nodes.
trivial style note:
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c [] > @@ -1737,6 +1737,7 @@ void task_numa_fault(int last_cpupid, int mem_node, int pages, int flags) > struct task_struct *p = current; > bool migrated = flags & TNF_MIGRATED; > int cpu_node = task_node(current); > + int local = !!(flags & TNF_FAULT_LOCAL);
Perhaps local would look nicer as bool and be better placed next to migrated.
bool migrated = flags & TNF_MIGRATED; bool local = flags & TNF_FAULT_LOCAL; int cpu_node = task_node(current);
> @@ -1785,6 +1786,17 @@ void task_numa_fault(int last_cpupid, int mem_node, int pages, int flags) > + if (!priv && !local && p->numa_group && > + node_isset(cpu_node, p->numa_group->active_nodes) && > + node_isset(mem_node, p->numa_group->active_nodes)) > + local = 1;
local = true;
| |