Messages in this thread | | | Date | Thu, 10 Apr 2014 14:49:28 +0200 | From | Denys Vlasenko <> | Subject | Re: [RFC PATCH v2 6/6] uprobes/x86: Emulate rip-relative conditional "near" jmp's |
| |
On 04/09/2014 09:44 PM, Oleg Nesterov wrote: > + case 0x0f: > + if (insn->opcode.nbytes != 2) > + return -ENOSYS; > + /* > + * If it is a "near" conditional jmp, OPCODE2() - 0x10 matches > + * OPCODE1() of the "short" jmp which checks the same condition. > + */
I propose:
/* * Near conditional jump opcodes: 0f 80..8f * Short conditional jump opcodes: 70..7f * Convert OPCODE2() to corresponding short jump opcode: */
> + opc1 = OPCODE2(insn) - 0x10; > default:
| |