lkml.org 
[lkml]   [2014]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 00/12] can: c_can: Fix a series of serious bugs and improve the performance
On Tue, 1 Apr 2014, Marc Kleine-Budde wrote:
> On 04/01/2014 12:35 AM, Thomas Gleixner wrote:
> > Dear Maintainers,
> >
> > On Tue, 18 Mar 2014, Thomas Gleixner wrote:
> >> The driver is full of serious bugs:
> >>
> >> - Two HW init routines are not spec compliant.
> >>
> >> - Completely defective message buffer handling in several ways
> >> That leads to interrupt storms and complete lockups.
> >>
> >> - Complete lack of SMP awareness
> >>
> >> What's amazing is that people "optimize" and "fix" the driver over and
> >> over, but nobody bothered to understand the manual and repair the code
> >> for real.
> >>
> >> The series fixes _ALL_ bugs which I found so far, but I'm sure there
> >> are more issues burried in that unreadable mess. I'm just not able to
> >> trigger them.
> >
> > What's the state of this series?
>
> I'll apply your patches today.

Thanks! Please drop the last one which was not part of the series:

Subject: can: c_can: Reduce interrupt load by 50%

While it works like a charm, we've seen an odd case were TX started to
stall. Had not yet time to dig into that.

Thanks,

tglx


\
 
 \ /
  Last update: 2014-04-01 12:01    [W:0.071 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site