lkml.org 
[lkml]   [2014]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and register write
On Fri,  7 Mar 2014 11:13:27 -0800
Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:

> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> drivers/tty/serial/xilinx_uartps.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index a4bd6242e72d..a39c2d290902 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1082,11 +1082,7 @@ static void xuartps_console_write(struct console *co, const char *s,
>
> xuartps_writel(ctrl, XUARTPS_CR_OFFSET);
>
> - /* restore interrupt state, it seems like there may be a h/w bug
> - * in that the interrupt enable register should not need to be
> - * written based on the data sheet
> - */
> - xuartps_writel(~imr, XUARTPS_IDR_OFFSET);
> + /* restore interrupt state */

It would be appropriate for the changelog at least to explain why the
note about the data sheet differing is going away !


\
 
 \ /
  Last update: 2014-03-07 23:21    [W:0.090 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site