lkml.org 
[lkml]   [2014]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[for-next][PATCH 15/20] ftrace: Inline the code from ftrace_dyn_table_alloc()
    From: Jiri Slaby <jslaby@suse.cz>

    The function used to do allocations some time ago. This no longer
    happens and it only checks the count and prints some info. This patch
    inlines the body to the only caller. There are two reasons:
    * the name of the function was misleading
    * it's clear what is going on in ftrace_init now

    Link: http://lkml.kernel.org/r/1393268401-24379-2-git-send-email-jslaby@suse.cz

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    kernel/trace/ftrace.c | 25 ++++++-------------------
    1 file changed, 6 insertions(+), 19 deletions(-)

    diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
    index 3f95bbe..76b6ed2 100644
    --- a/kernel/trace/ftrace.c
    +++ b/kernel/trace/ftrace.c
    @@ -2465,22 +2465,6 @@ ftrace_allocate_pages(unsigned long num_to_init)
    return NULL;
    }

    -static int __init ftrace_dyn_table_alloc(unsigned long num_to_init)
    -{
    - int cnt;
    -
    - if (!num_to_init) {
    - pr_info("ftrace: No functions to be traced?\n");
    - return -1;
    - }
    -
    - cnt = num_to_init / ENTRIES_PER_PAGE;
    - pr_info("ftrace: allocating %ld entries in %d pages\n",
    - num_to_init, cnt + 1);
    -
    - return 0;
    -}
    -
    #define FTRACE_BUFF_MAX (KSYM_SYMBOL_LEN+4) /* room for wildcards */

    struct ftrace_iterator {
    @@ -4403,10 +4387,13 @@ void __init ftrace_init(void)
    goto failed;

    count = __stop_mcount_loc - __start_mcount_loc;
    -
    - ret = ftrace_dyn_table_alloc(count);
    - if (ret)
    + if (!count) {
    + pr_info("ftrace: No functions to be traced?\n");
    goto failed;
    + }
    +
    + pr_info("ftrace: allocating %ld entries in %ld pages\n",
    + count, count / ENTRIES_PER_PAGE + 1);

    last_ftrace_enabled = ftrace_enabled = 1;

    --
    1.8.5.3



    \
     
     \ /
      Last update: 2014-03-07 18:41    [W:8.718 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site