lkml.org 
[lkml]   [2014]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCHv3 1/2] mm: introduce vm_ops->map_pages()
    Date
    Andrew Morton <akpm@linux-foundation.org> writes:
    > On Thu, 27 Feb 2014 21:53:46 +0200 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
    >> +
    >> +void do_set_pte(struct vm_area_struct *vma, unsigned long address,
    >> + struct page *page, pte_t *pte, bool write, bool anon);
    >> #endif
    >>
    >> /*
    >
    > lguest made a dubious naming decision:
    >
    > drivers/lguest/page_tables.c:890: error: conflicting types for 'do_set_pte'
    > include/linux/mm.h:593: note: previous declaration of 'do_set_pte' was here
    >
    > I'll rename lguest's do_set_pte() to do_guest_set_pte() as a
    > preparatory patch.

    s/do_/ if you don't mind; if we're going to prefix it, we don't need the
    extra verb.

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2014-03-05 19:02    [W:3.931 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site