Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCHv3 1/2] mm: introduce vm_ops->map_pages() | Date | Wed, 05 Mar 2014 10:34:15 +1030 |
| |
Andrew Morton <akpm@linux-foundation.org> writes: > On Thu, 27 Feb 2014 21:53:46 +0200 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote: >> + >> +void do_set_pte(struct vm_area_struct *vma, unsigned long address, >> + struct page *page, pte_t *pte, bool write, bool anon); >> #endif >> >> /* > > lguest made a dubious naming decision: > > drivers/lguest/page_tables.c:890: error: conflicting types for 'do_set_pte' > include/linux/mm.h:593: note: previous declaration of 'do_set_pte' was here > > I'll rename lguest's do_set_pte() to do_guest_set_pte() as a > preparatory patch.
s/do_/ if you don't mind; if we're going to prefix it, we don't need the extra verb.
Thanks, Rusty.
| |