Messages in this thread | | | Date | Wed, 26 Mar 2014 21:09:09 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition |
| |
Hi,
On Wed, Mar 26, 2014 at 08:47:15PM -0400, Peter Hurley wrote: > [ +to Marcel Holtmann ] > > On 03/20/2014 03:30 PM, Felipe Balbi wrote: > >LDISCs shouldn't call tty->ops->write() from within > >->write_wakeup(). > > > >->write_wakeup() is called with port lock taken and > >IRQs disabled, tty->ops->write() will try to acquire > >the same port lock and we will deadlock. > > > >Reviewed-by: Peter Hurley <peter@hurleysoftware.com> > >Reported-by: Huang Shijie <b32955@freescale.com> > >Signed-off-by: Felipe Balbi <balbi@ti.com> > > I just noticed this patch wasn't addressed to Marcel; > seems like this should go through the bluetooth tree (but not > through bluetooth-next because it fixes an oops).
read the archives:
http://marc.info/?l=linux-bluetooth&m=139534449409583&w=2
> Marcel, > > You may want to build on top of this patch split handling; > I noticed some of the protocol drivers are calling > hci_uart_tx_wakeup() from work functions already (so don't > need to schedule another work...)
I don't think that should be part of $subject, though.
-- balbi [unhandled content-type:application/pgp-signature] | |