Messages in this thread | | | Date | Fri, 21 Mar 2014 08:58:34 +0800 | Subject | Re: [PATCH 3/3] regulator: bcm590xx: Use array to save desc and *info | From | Axel Lin <> |
| |
2014-03-20 23:42 GMT+08:00 Matt Porter <mporter@linaro.org>: > On Fri, Mar 14, 2014 at 10:00:28AM +0800, Axel Lin wrote: >> BCM590XX_NUM_REGS is known in compile time. >> Use array to save desc and *info makes the code simpler. >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> > > Well, ok. It was coded for dynamic allocation because I'm starting to > work on BCM59054 support, which is similar but different. The actual > regulators are different but, due to luck, the total number is the > same between 59056 and 59054...so this can still work for the moment. > However, another 590xx part does have a different number of regulators > so I'm not sure this is worth doing when we know we'll go back to > dynamic allocation in the future.
Then it' ok to keep the code as is, just drop this patch.
Regards, Axel
| |