Messages in this thread | | | Date | Fri, 21 Mar 2014 01:23:53 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 2/2] coding style: fix line over 80 characters |
| |
On 03/20/2014 11:45 PM, Joe Perches wrote:
>>> diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c > [] >>> @@ -271,12 +271,14 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, >>> } >>> break; >>> case USB_PORT_FEAT_POWER: >>> - usbip_dbg_vhci_rh(" ClearPortFeature: USB_PORT_FEAT_POWER\n"); >>> + usbip_dbg_vhci_rh( >>> + " ClearPortFeature: USB_PORT_FEAT_POWER\n");
>> Your version of scripts/checkpatch.pl seems outdated. It shouldn't >> complain about strings violating 80-column limit (and I've just verified it >> doesn't).
> checkpatch complains about > 80 char lines for lines with > a function where the function name isn't understood to be > a logging use.
> uspip_dbg_<foo> doesn't take the general form so if the > string at the EOL exceeds 80 chars, a message is emitted.
> Long standalone strings on a single line do not get warnings.
OK, but there's still issue that the patch context doesn't correspond to what can be seen in Greg's tree. What I am seeing there is broken up string.
WBR, Sergei
| |