Messages in this thread | | | Subject | Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments | From | Joe Perches <> | Date | Thu, 20 Mar 2014 05:44:45 -0700 |
| |
On Thu, 2014-03-20 at 05:41 -0700, Brian Norris wrote: > I also don't think that a function parameter is the right place to > mark const like this. Function arguments are always pass-by-value, so > this 'const' tells users (callers) nothing useful. It only provides > useless constraints on what the function can do with its copy of the > parameter.
Again, that's not useless information.
And as you've seen, just making these changes can be error prone.
| |