Messages in this thread | | | Date | Thu, 20 Mar 2014 12:18:10 +0100 | From | Simon Budig <> | Subject | Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support |
| |
On 20/03/14 10:37, Mark Rutland wrote: > On Wed, Mar 19, 2014 at 01:09:20PM +0000, Lothar Waßmann wrote: >> +FocalTech EDT-FT5x06 Polytouch driver >> +===================================== >> + >> +Required properties: >> + - compatible: "edt,edt-ft5x06" > > Is the 'x' part of a particular product name, or is this a class of > devices?
The driver is intended for the EDT "polytouch" family touches, which are based on a focaltec controller. The current line of touches uses e.g. the ft5306 as well as the ft5406 focaltec controller.
> It's preferable to have a specific string which another similar variants > can claim compatibility with (while also additionally having a more > specific string), as this makes it possible to handle variants more > specially in future, target workarounds, etc.
I chose the driver name since I wanted to differentiate from other EDT touches, which used a different controller. With hindsight it was unfortunately confusing, since I get quite some request from people, who also have a device based on the focaltec controllers, but with a very different firmware (and communication protocol). They got tricked into thinking that this driver would be suitable...
If I were to chose the name again I'd probably pick "edt-polytouch" or something like this. But I doubt that it is useful to change the name now.
Bye, Simon
-- Simon Budig kernel concepts GmbH simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48 +49-271-771091-17 D-57072 Siegen
[unhandled content-type:application/pgp-signature] | |