Messages in this thread | | | Date | Wed, 19 Mar 2014 10:19:16 +0530 | Subject | Re: [PATCH] timer: remove code redundancy while calling get_nohz_timer_target() | From | Viresh Kumar <> |
| |
On 18 March 2014 21:14, Frederic Weisbecker <fweisbec@gmail.com> wrote: > On Tue, Mar 18, 2014 at 04:26:07PM +0530, Viresh Kumar wrote: >> + if (pinned || !get_sysctl_timer_migration() || !idle_cpu(cpu)) >> + return cpu; > > Maybe the pinned part should stay a caller detail. Although I don't really mind.
I tried that initially, but in that case the callers would have to call smp_processor_id() in the else part and so decided to put that as well into this routine only.
> The patch looks good!
Thanks.
| |