Messages in this thread | | | Date | Thu, 20 Mar 2014 01:53:02 +0000 | From | Greg KH <> | Subject | Re: [PATCHv2 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c |
| |
On Wed, Mar 19, 2014 at 11:56:14PM +0100, Mathieu Maret wrote: > Multi statement macro should use do{}while(0) > > patch v2 does not break compilation > --- > drivers/staging/wlags49_h2/wl_netdev.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c > index 255d291..0e553ae 100644 > --- a/drivers/staging/wlags49_h2/wl_netdev.c > +++ b/drivers/staging/wlags49_h2/wl_netdev.c > @@ -107,9 +107,11 @@ > * macros > ******************************************************************************/ > #define BLOCK_INPUT(buf, len) \ > - desc->buf_addr = buf; \ > - desc->BUF_SIZE = len; \ > - status = hcf_rcv_msg(&(lp->hcfCtx), desc, 0) > + do { \ > + desc->buf_addr = buf; \ > + desc->BUF_SIZE = len; \ > + status = hcf_rcv_msg(&(lp->hcfCtx), desc, 0); \ > + } while (0)
This patch is already in my tree :(
thanks,
greg k-h
| |