Messages in this thread | | | Date | Wed, 19 Mar 2014 13:28:48 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH] of: Make of_find_node_by_path() handle /aliases |
| |
On 03/18/2014 03:52 PM, Pantelis Antoniou wrote: > Make of_find_node_by_path() handle aliases as prefixes. > > Originally by David Daney <ddaney@caviumnetworks.com>, but > reworked according to remark by Grant Likely. > > Handles all cases without allocating memory as requested by > Grant Likely <grant.likely@linaro.org>
Why not just introduce a new function of_find_node_by_alias()? A single unified function would make sense if the function did something like: (1) find my path, and return if found (2) if not found, fall back to searching /aliases. However, since this modified function takes 2 separate formats of input path based on whether it should search for an alias or not, it seems like 2 separate functions would be a better API. Perhaps the new API should simply be a wrapper around of_find_node_by_path, once the alias has been found?
| |