Messages in this thread | | | Subject | Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01 | From | Krzysztof Kozlowski <> | Date | Wed, 19 Mar 2014 13:41:59 +0100 |
| |
On Wed, 2014-03-19 at 09:14 +0000, Lee Jones wrote: > > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > > rtc-s5m driver does not support S2MPA01. > > > > This fixes following error: > > drivers/mfd/sec-core.c:342:45: warning: ‘regmap_rtc’ may be used uninitialized in this function [-Wuninitialized] > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > drivers/mfd/sec-core.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Please don't send patches in the middle of threads like this (v2's are > a different story as it saves on re-sending entire patch-sets), as I > very nearly missed it.
OK, I understand. I put it in the middle because it was a follow up of your immutable branch ib-mfd-regulator-3.15 (merging mine S2MPS14 and Sachin's S2MPA01).
> > We already have drivers doing similar things so I'll apply this as a > temporary fix, but please find something a little less 'hacky' to > supersede it _soon_.
Sure, I just sent a patch for it.
Best regards, Krzysztof
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |