Messages in this thread | | | Date | Tue, 18 Mar 2014 00:37:25 +0000 | From | Greg KH <> | Subject | Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0 |
| |
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: > I think vmalloc/kmalloc in uislib_malloc() can be removed and just use > vmalloc/kmalloc directly.
Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being used, but cc: the driver maintainers just to be sure.
> (UISMALLOC() macro is also removed.)
Yes.
> And uislib_malloc() is renamed to "uislib_trace_buffer_status()" which > is just tracing buffer status(Malloc_FailuresAlloc, Malloc_BytesInUse > ...) for info_proc_read_helper().
The whole tracing stuff needs to be ripped out, so no problem deleting it here as well.
> If this change is accepted, it also need to change uislib_free().
Drop it and just use kfree().
thanks,
greg k-h
| |