lkml.org 
[lkml]   [2014]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] SPI: Add driver for Cadence SPI controller
From
On Mon, Mar 17, 2014 at 2:22 PM, Michal Simek <monstr@monstr.eu> wrote:
>>> + return 0;
>>> +}
>>> +
>>> +static SIMPLE_DEV_PM_OPS(cdns_spi_dev_pm_ops, cdns_spi_suspend,
>>> + cdns_spi_resume);
>>> +
>>> +/* Work with hotplug and coldplug */
>>> +MODULE_ALIAS("platform:" CDNS_SPI_NAME);
>>
>> Not sure, but I don't think this should be needed.
>
> I don't know too.

A plain platform device driver needs the MODULE_ALIAS, unless there's
a "MODULE_DEVICE_TABLE(platform, ...)", which doesn't exist in this driver.

However, as the driver fails in the absence of DT:

ret = of_property_read_u16(pdev->dev.of_node, "num-chip-select",
&master->num_chipselect);
if (ret < 0) {
dev_err(&pdev->dev, "couldn't determine num-chip-select\n");
goto clk_dis_all;
}

it won't work (yet) as a plain platform device driver.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2014-03-17 16:01    [W:0.084 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site