lkml.org 
[lkml]   [2014]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] x86_32: Remove user bit from identity map PDE
On Wed, Mar 12, 2014 at 11:39 AM, Dave Jones <davej@redhat.com> wrote:
> On Wed, Mar 12, 2014 at 11:29:45AM -0700, Andy Lutomirski wrote:
> > The only reason that the user bit was set was to support userspace
> > access to the compat vDSO in the fixmap. The compat vDSO is gone,
> > so the user bit can be removed.
> >
> > -/*
> > - * For PDE_IDENT_ATTR include USER bit. As the PDE and PTE protection
> > - * bits are combined, this will alow user to access the high address mapped
> > - * VDSO in the presence of CONFIG_COMPAT_VDSO
> > - */
> > #define PTE_IDENT_ATTR 0x003 /* PRESENT+RW */
> > -#define PDE_IDENT_ATTR 0x067 /* PRESENT+RW+USER+DIRTY+ACCESSED */
> > +#define PDE_IDENT_ATTR 0x063 /* PRESENT+RW+USER+DIRTY+ACCESSED */
> > #define PGD_IDENT_ATTR 0x001 /* PRESENT (no other attributes) */
>
> update the comment too ?

Damnit. I fixed this for the other patchset...

--Andy

>
> Dave
>



--
Andy Lutomirski
AMA Capital Management, LLC


\
 
 \ /
  Last update: 2014-03-12 23:01    [W:0.095 / U:2.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site