Messages in this thread | | | Subject | Re: [PATCH V2 bluetooth-next 2/6] bluetooth: Convert uses of __constant_<foo> to <foo> | From | Joe Perches <> | Date | Wed, 12 Mar 2014 11:22:34 -0700 |
| |
On Wed, 2014-03-12 at 11:11 -0700, Marcel Holtmann wrote:
> > /* Connection accept timeout ~20 secs */ > > - param = __constant_cpu_to_le16(0x7d00); > > + param = cpu_to_le16(0x7d00); > > > > 0x7d00 is 32000, presumably that's 32 seconds. > > so it is 0x7d00 * 0.625 which results in 20 seconds.
Hi again Marcel.
Swell. No worries then.
Is this clocking divisor defined somewhere? Is .625 or 5/8 as a magic number defined somewhere? (I didn't see it in a brief scan) Maybe it'd be better to use 20000 * 5 / 8 or add some define like
#define msecs_to_bt_clocks(ms) ((ms) * 5 / 8)
> > and > > /* 160 msec page scan interval */ > > - acp.interval = __constant_cpu_to_le16(0x0100); > > + acp.interval = cpu_to_le16(0x0100); > > 256 msecs? > > also here 0x0100 * 0.625 resulting in 160 msecs.
Same as above.
> patch has been applied to bluetooth-next tree.
cheers, Joe
| |