lkml.org 
[lkml]   [2014]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 3/4] irqchip: sun4i: Fix a comment about mask register initialization
    Date
    The comment was claiming that we were masking all irqs, while the code actually
    *un*masks all of them.

    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
    ---
    drivers/irqchip/irq-sun4i.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/irqchip/irq-sun4i.c b/drivers/irqchip/irq-sun4i.c
    index 5c25048..8a2fbee 100644
    --- a/drivers/irqchip/irq-sun4i.c
    +++ b/drivers/irqchip/irq-sun4i.c
    @@ -109,7 +109,7 @@ static int __init sun4i_of_init(struct device_node *node,
    writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(1));
    writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(2));

    - /* Mask all the interrupts */
    + /* Unmask all the interrupts, ENABLE_REG(x) is used for masking */
    writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(0));
    writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(1));
    writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(2));
    --
    1.9.0


    \
     
     \ /
      Last update: 2014-03-12 21:21    [W:2.560 / U:0.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site